[webkit-reviews] review denied: [Bug 105242] [Shadow] LargeDistributionWithLayout.html should be updated : [Attachment 179864] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 17 19:30:22 PST 2012


Ryosuke Niwa <rniwa at webkit.org> has denied Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 105242: [Shadow] LargeDistributionWithLayout.html should be updated
https://bugs.webkit.org/show_bug.cgi?id=105242

Attachment 179864: Patch
https://bugs.webkit.org/attachment.cgi?id=179864&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179864&action=review


> PerformanceTests/ChangeLog:9
> +	   Since this test was written when distribution took O(N^2). However,
now it's almost O(N), so this test finishes
> +	   in very short time. Also, this test contains a some error to cause
test failure, it also should be fixed.

We should use run/s in this test instead.


More information about the webkit-reviews mailing list