[webkit-reviews] review granted: [Bug 104827] [EFL] Build break with latest EFL libraries. : [Attachment 179104] first draft

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.gombos at webkit.org> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 104827: [EFL] Build break with latest EFL libraries.
https://bugs.webkit.org/show_bug.cgi?id=104827

Attachment 179104: first draft
https://bugs.webkit.org/attachment.cgi?id=179104&action=review

------- Additional Comments from Laszlo Gombos <laszlo.gombos at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179104&action=review


Make sense to me.

> Source/cmake/OptionsEfl.cmake:126
> +# Add Eo dependency if EFL version is equal to or greater 1.8
> +if (${EVAS_VERSION} VERSION_EQUAL 1.8 AND ${ECORE_VERSION} VERSION_EQUAL
1.8)

Comment does not seem to say what the code actually does. VERSION_EQUAL checks
for "equal or greater" ?