[webkit-reviews] review denied: [Bug 104845] window.crypto.getRandomValues should return the input ArrayBufferView : [Attachment 179175] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Ryan Sleevi
<rsleevi at chromium.org>'s request for review:
Bug 104845: window.crypto.getRandomValues should return the input
ArrayBufferView
https://bugs.webkit.org/show_bug.cgi?id=104845

Attachment 179175: Patch
https://bugs.webkit.org/attachment.cgi?id=179175&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179175&action=review


> Source/WebCore/ChangeLog:7
> +

Here please describe the rationale for your change.

> Source/WebCore/ChangeLog:17
> +	   * GNUmakefile.list.am:
> +	   * Target.pri:
> +	   * UseJSC.cmake:
> +	   * WebCore.xcodeproj/project.pbxproj:
> +	   * bindings/js/JSArrayBufferViewCustom.cpp: Added.
> +	   (WebCore):
> +	   (WebCore::toJS): Added toJS() for ArrayBufferView
> +	   * bindings/js/JSBindingsAllInOne.cpp:

I'm not sure why we need to add custom toJS() for JSC. What happens if you
change the [CustomToJSObject] to [V8CustomToJSObject] ? Then toJS() for JSC
will be auto-generated as expected, won't it?

> Source/WebCore/ChangeLog:18
> +	   * bindings/v8/custom/V8ArrayBufferViewCustom.cpp:

What happens if you simply remove [CustomToJSOObject] ? Then the wrap() will be
auto-generated as expected, won't it? (I'm not sure. This might not work.)