[webkit-reviews] review denied: [Bug 104990] Coordinated Graphics: Manage the lifecycle of CoordinatedGraphicsLayer explicitly. : [Attachment 179412] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 104990: Coordinated Graphics: Manage the lifecycle of
CoordinatedGraphicsLayer explicitly.
https://bugs.webkit.org/show_bug.cgi?id=104990

Attachment 179412: Patch
https://bugs.webkit.org/attachment.cgi?id=179412&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179412&action=review


> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:353
> +    OwnPtr<WebCore::GraphicsLayer> newLayer = GraphicsLayer::create(0,
this);

What does 0 stand for?

> Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:592
> +    m_rootLayer = GraphicsLayer::create(0, this);

What does 0 stand for?

>
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.
h:179
> +    Vector<CoordinatedLayerID> m_attachedLayers;
>      Vector<CoordinatedLayerID> m_detachedLayers;

Let's rename to m_layersToCreate and m_layersToDelete