[webkit-reviews] review granted: [Bug 97359] AX: support clickPoint in DRT for chromium : [Attachment 179810] Patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has granted Dominic Mazzoni
<dmazzoni at google.com>'s request for review:
Bug 97359: AX: support clickPoint in DRT for chromium
https://bugs.webkit.org/show_bug.cgi?id=97359

Attachment 179810: Patch
https://bugs.webkit.org/attachment.cgi?id=179810&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=179810&action=review


>
Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp
:742
> +    if (arguments.size() != 2 || !arguments[0].isNumber() ||
!arguments[1].isNumber()) {

you could set result->setNull() at the top and then be able to just return on
the failure case here and...

>
Tools/DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp
:752
> +	   result->setNull();

here