[webkit-reviews] review granted: [Bug 105217] Cleanup --profiler=perf code a little and allow up to 1000 report files (instead of 100) : [Attachment 179804] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 105217: Cleanup --profiler=perf code a little and allow up to 1000 report
files (instead of 100)
https://bugs.webkit.org/show_bug.cgi?id=105217

Attachment 179804: Patch
https://bugs.webkit.org/attachment.cgi?id=179804&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179804&action=review


> Tools/Scripts/webkitpy/common/system/profiler.py:89
> +	   # FIXME: Currently all reports are kept as test.*, until we fix
that, search more than 100 names before giving up.

Nit: "search up to 1000 names" rather than "search more than 100 names" ?

> Tools/Scripts/webkitpy/common/system/profiler.py:173
> +	   print  # An extra line between tests looks nicer.

Nit: I wouldn't bother w/ the comment here ...