[webkit-reviews] review granted: [Bug 104843] Have kFixedPointDenominator be constant across ports : [Attachment 179126] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 17 14:06:16 PST 2012


Julien Chaffraix (vacations 20 dec -> 5 jan) <jchaffraix at webkit.org> has
granted Emil A Eklund <eae at chromium.org>'s request for review:
Bug 104843: Have kFixedPointDenominator be constant across ports
https://bugs.webkit.org/show_bug.cgi?id=104843

Attachment 179126: Patch
https://bugs.webkit.org/attachment.cgi?id=179126&action=review

------- Additional Comments from Julien Chaffraix (vacations 20 dec -> 5 jan)
<jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179126&action=review


r=me, but let's give the port maintainer some time to comment if there is
something we missed.

> Source/WebCore/ChangeLog:22
> +	   Change to clamp and then round.

As discussed, I would just not do this change as it's unrelated. Next time,
please explain 'why' you did that instead of having me guess what was the
intent.


More information about the webkit-reviews mailing list