[webkit-reviews] review granted: [Bug 100398] [CSS Exclusions] shape-outside on floats for rectangle shapes height/width : [Attachment 179361] Updated Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix (vacations 20 dec -> 5 jan) <jchaffraix at webkit.org> has
granted Bem Jones-Bey <bjonesbe at adobe.com>'s request for review:
Bug 100398: [CSS Exclusions] shape-outside on floats for rectangle shapes
height/width
https://bugs.webkit.org/show_bug.cgi?id=100398

Attachment 179361: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=179361&action=review

------- Additional Comments from Julien Chaffraix (vacations 20 dec -> 5 jan)
<jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179361&action=review


I got an explaination why the tests are fine: shape-inside defaults to
shape-outside. That's what confused me and there is a good use case for that so
it shouldn't block the patch.

> Source/WebCore/rendering/RenderBlock.cpp:3933
> +	   // The CSS Exclusions specification says that the margins are
ignored
> +	   // when a float has a shape outside.

Nit: No wrapping.

> Source/WebCore/rendering/RenderBlock.cpp:3965
> +		   // The CSS Exclusions specification says that the margins
are ignored
> +		   // when a float has a shape outside.

Ditto.