[webkit-reviews] review granted: [Bug 99588] Use forwarder2 in Chrome for Android layout tests. : [Attachment 179740] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Philippe Liard
<pliard at chromium.org>'s request for review:
Bug 99588: Use forwarder2 in Chrome for Android layout tests.
https://bugs.webkit.org/show_bug.cgi?id=99588

Attachment 179740: Patch
https://bugs.webkit.org/attachment.cgi?id=179740&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179740&action=review


This looks much better.  Thanks!

> Tools/ChangeLog:40
> +	   * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
> +	   * Scripts/webkitpy/common/system/executive.py:
> +	   (Executive.run_command):
> +	   * Scripts/webkitpy/layout_tests/port/chromium_android.py:
> +	   (ChromiumAndroidPort.setup_test_run):
> +	   (ChromiumAndroidPort.check_build):
> +	   (ChromiumAndroidPort.path_to_host_forwarder):
> +	   (ChromiumAndroidPort):
> +	   (ChromiumAndroidPort.path_to_device_forwarder):

Please regenerate the ChangeLog.  You can run prepare-ChangeLog to do that.