[webkit-reviews] review requested: [Bug 105044] REGRESSION (r137607): Cannot download files, =?UTF-8?Q?=20stuck=20in=20=E2=80=9CPreparing=20to=20download=E2=80=9D=20?=: [Attachment 179748] Fix the regression

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 105044: REGRESSION (r137607): Cannot download files, stuck in “Preparing to
download”
https://bugs.webkit.org/show_bug.cgi?id=105044

Attachment 179748: Fix the regression
https://bugs.webkit.org/attachment.cgi?id=179748&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
It appears that in r137607 we call DocumentLoader::mainReceivedError(), which
now calls MainResourceLoader::cancel(), which cancels the CachedResource load,
which cancels the ResourceLoader, which cancels the ResourceHandle.

Calling directly into ResourceLoader::didFail() instead is a bit of a layering
violation, but it emulates the old behavior quite well.  Strictly speaking, it
isn't necessary to make downloads work, but if we don't, the loader objects
(ResourceLoader, CachedResource, MainResourceLoader) will be left alive but
useless until the associated DocumentLoader is detached.