[webkit-reviews] review canceled: [Bug 103944] Web Inspector: Persist Audit selections across sessions : [Attachment 179712] Patch

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has canceled Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 103944: Web Inspector: Persist Audit selections across sessions
https://bugs.webkit.org/show_bug.cgi?id=103944

Attachment 179712: Patch
https://bugs.webkit.org/attachment.cgi?id=179712&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179712&action=review


> Source/WebCore/inspector/front-end/AuditLauncherView.js:69
> +WebInspector.AuditLauncherView.AllCategoriesKey = "__AllCategories";

This can be a computed setting (will slightly break when more categories from
new extensions are added, though)

> Source/WebCore/inspector/front-end/AuditLauncherView.js:268
> +    _selectedCategoriesUpdated: function()

Could you clean up the persisted list of categories to remove junk (e.g.
leftover categories from disabled/removed extensions) here?