[webkit-reviews] review granted: [Bug 104436] [Qt] MinGW-w64 64-bit build fails when linking libQt5WebKitWidgetsd : [Attachment 179585] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Jonathan Liu
<net147 at gmail.com>'s request for review:
Bug 104436: [Qt] MinGW-w64 64-bit build fails when linking libQt5WebKitWidgetsd
https://bugs.webkit.org/show_bug.cgi?id=104436

Attachment 179585: Patch
https://bugs.webkit.org/attachment.cgi?id=179585&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me

Theoretically this line could also be placed elsewhere (it's a config, not a
per-library kind of thing), but then having it near the --whole-archive LIBS
addition makes it clearer that those two are related.

Yeah I don't think it's an actual _rule_ that the first line has to be that,
but webkit-patch chooses it as default when filling out ChangeLogs. That I
think is a sensible default and if the title of the bug is suitable for the
changelog, then it's a good fit. Otherwise I think anyone is free to change it.