[webkit-reviews] review denied: [Bug 105009] [EFL][DRT] Isolates GTK specific code in DumpRenderTree/gtk : [Attachment 179462] [EFL][DRT] Isolates GTK specific code in DumpRenderTree/gtk
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Dec 16 00:44:28 PST 2012
Martin Robinson <mrobinson at webkit.org> has denied Krzysztof Czech
<k.czech at samsung.com>'s request for review:
Bug 105009: [EFL][DRT] Isolates GTK specific code in DumpRenderTree/gtk
https://bugs.webkit.org/show_bug.cgi?id=105009
Attachment 179462: [EFL][DRT] Isolates GTK specific code in DumpRenderTree/gtk
https://bugs.webkit.org/attachment.cgi?id=179462&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
Instead of first splicing a file in the directory with #ifdefs I think it makes
sense to move shared code to a shared directory, while keeping
platform-specific methods or functions in the GTK+ directory. This is the
structure that many classes in WebCore use. It is based on the fact that the
implementation of various class methods can be spread across compilation units.
More information about the webkit-reviews
mailing list