[webkit-reviews] review granted: [Bug 105046] [CSSRegions] Pseudo-elements should not be directly collected into a named flow : [Attachment 179519] Patch

[bugzilla-daemon at webkit.org]

Abhishek Arya <inferno at chromium.org> has granted Mihnea Ovidenie
<mihnea at adobe.com>'s request for review:
Bug 105046: [CSSRegions] Pseudo-elements should not be directly collected into
a named flow
https://bugs.webkit.org/show_bug.cgi?id=105046

Attachment 179519: Patch
https://bugs.webkit.org/attachment.cgi?id=179519&action=review

------- Additional Comments from Abhishek Arya <inferno at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179519&action=review


> LayoutTests/ChangeLog:8
> +	   Prevent pseudo-elements to be collected into a named-flow by bailing
out early in the collecting stage.

Please add the spec link here.

> LayoutTests/fast/regions/pseudo-before-content-node-expected.txt:5
> +PASS

Any idea why the :after content 'a' is not showing here.

> LayoutTests/fast/regions/pseudo-first-line-content-node-expected.txt:5
> +aaaaa

Instead of using 'a', 'aaaa', etc, please use descriptive words like
':first-line content', ':before content', etc.