[webkit-reviews] review granted: [Bug 105081] Remove in-band text tracks when media element's src changes : [Attachment 179576] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 15 18:29:33 PST 2012


Sam Weinig <sam at webkit.org> has granted Eric Carlson <eric.carlson at apple.com>'s
request for review:
Bug 105081: Remove in-band text tracks when media element's src changes
https://bugs.webkit.org/show_bug.cgi?id=105081

Attachment 179576: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=179576&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179576&action=review


> Source/WebCore/html/HTMLMediaElement.cpp:2788
> +    beginIgnoringTrackDisplayUpdateRequests();

It might add some point make sense to add an RAII object to use scope to
control this bounding.


More information about the webkit-reviews mailing list