[webkit-reviews] review granted: [Bug 105077] webkitpy: move --lint-test-files code into its own module : [Attachment 179570] fix main() call in lint-test-expectations
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 14 23:35:38 PST 2012
Eric Seidel <eric at webkit.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 105077: webkitpy: move --lint-test-files code into its own module
https://bugs.webkit.org/show_bug.cgi?id=105077
Attachment 179570: fix main() call in lint-test-expectations
https://bugs.webkit.org/attachment.cgi?id=179570&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179570&action=review
Looks like you're mostly moving code. LGTM.
> Tools/Scripts/webkitpy/layout_tests/lint_test_expectations.py:49
> +def lint(host, options, logging_stream):
Eventually we should probably make this a class so we can break it down into
smaller helper methods. :)
More information about the webkit-reviews
mailing list