[webkit-reviews] review granted: [Bug 102448] PDFPlugin: The "Open in Preview" HUD button should work : [Attachment 179550] rebase

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 102448: PDFPlugin: The "Open in Preview" HUD button should work
https://bugs.webkit.org/show_bug.cgi?id=102448

Attachment 179550: rebase
https://bugs.webkit.org/attachment.cgi?id=179550&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179550&action=review


> Source/WebKit2/UIProcess/API/mac/PDFViewController.mm:581
> +	   m_temporaryPDFUUID = WebCore::createCanonicalUUIDString();

Can "using namespace WebCore" be added to this file?

> Source/WebKit2/UIProcess/WebPageProxy.h:730
> +    void savePDFToTemporaryFolderAndOpenWithNativeApplicationRaw(const
String& suggestedFilename, const String& originatingURLString, const uint8_t*
data, unsigned long size, const String& pdfUUID);
> +    void savePDFToTemporaryFolderAndOpenWithNativeApplication(const String&
suggestedFilename, const String& originatingURLString, const
CoreIPC::DataReference&, const String& pdfUUID);

I can't tell the difference between "raw" and "cooked" looking at this file. Is
there a semantic difference between these two?

> Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm:780
> +	   // FIXME: We should probably notify the user that they can't save
before the document is finished loading.
> +	   // PDFViewController does an NSBeep(), but that seems insufficient.

Would be nice to grey out the icon in HUD. It's too late to explain now!