[webkit-reviews] review granted: [Bug 104775] Cannot click an element at 2nd line or more inside inline-block in vertical writing mode. : [Attachment 179414] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 14 15:33:51 PST 2012


Dean Jackson <dino at apple.com> has granted Yuki Sekiguchi
<yuki.sekiguchi at access-company.com>'s request for review:
Bug 104775: Cannot click an element at 2nd line or more inside inline-block in
vertical writing mode.
https://bugs.webkit.org/show_bug.cgi?id=104775

Attachment 179414: Patch
https://bugs.webkit.org/attachment.cgi?id=179414&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=179414&action=review


I'm making some grammar suggestions. Please don't feel that I'm being overly
picky :)

> Source/WebCore/ChangeLog:8
> +	   If parent of inline box change writing mode, flipping offset is
responsibility of inline box.

"If the parent of an inline box changes writing mode, then the inline box must
flip incoming hit point coordinates."

> Source/WebCore/ChangeLog:9
> +	   If they don't flip offset, they misunderstand offset because their
origin is different from their parent's.

"Otherwise, the coordinate will be misunderstood because the box has a
different origin from its parent."

> Source/WebCore/ChangeLog:10
> +	   nodeAtPoint() in InlineTextBox and InlineFlowBox flip.

I don't think you need this line.

> Source/WebCore/ChangeLog:12
> +	   If InlineBox don't flip its offset, children of InlineBox use wrong
offset
> +	   because they don't(shouldn't) know that its grand parent changing
writing mode.

"If the InlineBox doesn't flip its offset, its children will use the wrong
offset
because they don't know their grandparent changed writing modes."

> LayoutTests/ChangeLog:8
> +	   test that we can click 2nd line inside inline-block in vertical
writing mode.

Nit: Test (with uppercase T).


More information about the webkit-reviews mailing list