[webkit-reviews] review granted: [Bug 104842] Disambiguate "background color" and "contents as solid color" on GraphicsLayer : [Attachment 179529] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 104842: Disambiguate "background color" and "contents as solid color" on
GraphicsLayer
https://bugs.webkit.org/show_bug.cgi?id=104842

Attachment 179529: Patch
https://bugs.webkit.org/attachment.cgi?id=179529&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=179529&action=review


> Source/WebCore/ChangeLog:23
> +2012-12-13  No'am Rosenthal	<noam.rosenthal at nokia.com>
> +
> +	   Disambiguate "background color" and "contents as solid color" on
GraphicsLayer
> +	   https://bugs.webkit.org/show_bug.cgi?id=104842
> +
> +	   Reviewed by Simon Fraser.
> +
> +	   Rename overloads in GraphicsLayerTextureMapper and
GraphicsLayerChromium to account for the rename in GraphicsLayer.
> +
> +	   Covered by existing tests.
> +
> +	   * platform/graphics/chromium/GraphicsLayerChromium.cpp:
> +	   * platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
> +	   (WebCore::GraphicsLayerTextureMapper::setContentsToSolidColor):
> +	   * platform/graphics/texmap/GraphicsLayerTextureMapper.h:
> +	   (GraphicsLayerTextureMapper):
> +	   (WebCore::GraphicsLayerTextureMapper::solidColor):
> +	   * platform/graphics/texmap/TextureMapperLayer.cpp:
> +	   (WebCore::TextureMapperLayer::paintSelf):
> +	   (WebCore::TextureMapperLayer::flushCompositingStateSelf):
> +	   * platform/graphics/texmap/TextureMapperLayer.h:
> +	   (State):
> +

This confused me, but I understand now.