[webkit-reviews] review granted: [Bug 105052] Allow the text track contents to be displayed externally to WebCore. : [Attachment 179528] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 105052: Allow the text track contents to be displayed externally to
WebCore.
https://bugs.webkit.org/show_bug.cgi?id=105052

Attachment 179528: Patch
https://bugs.webkit.org/attachment.cgi?id=179528&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=179528&action=review


> Source/WebCore/html/shadow/MediaControlElements.cpp:1290
>      hasChildNodes() ? show() : hide();
> +
> +    if (hasChildNodes()) {

You might as well combine these (only call hasChildNodes once).

> Source/WebCore/platform/graphics/MediaPlayerPrivate.h:188
> +    virtual bool requiresTextTrackRepresentation() const { return 0; }

Nit: "return 0" -> "return false"