[webkit-reviews] review denied: [Bug 105051] [chromium] Enable LCD AA if text is painted inside opaque region : [Attachment 179517] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Alok Priyadarshi
<alokp at chromium.org>'s request for review:
Bug 105051: [chromium] Enable LCD AA if text is painted inside opaque region
https://bugs.webkit.org/show_bug.cgi?id=105051

Attachment 179517: Patch
https://bugs.webkit.org/attachment.cgi?id=179517&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179517&action=review


Won't this produce inconsistently rendered text within a layer depending on how
the paint rect interacts with the opaque region?

This patch doesn't appear to actually populate the rect at all, so I can't tell
where it is going to come from in general.

> Source/WebCore/platform/graphics/skia/PlatformContextSkia.cpp:449
> +bool PlatformContextSkia::adjustPaintFlagsForText(SkPaint* paint, const
SkRect* rect) const

I can't find any callers that pass in a non-null rect parameter - where are
they?