[webkit-reviews] review granted: [Bug 104545] Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and "loadHeapSnapshot" : [Attachment 178532] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Eugene Klyuchnikov
<eustas at chromium.org>'s request for review:
Bug 104545: Web Inspector: Profiler: split "getProfile" to "getCPUProfile" and
"loadHeapSnapshot"
https://bugs.webkit.org/show_bug.cgi?id=104545

Attachment 178532: Patch
https://bugs.webkit.org/attachment.cgi?id=178532&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178532&action=review


> Source/WebCore/inspector/Inspector.json:3035
> +		   "name": "loadHeapSnapshot",

I'd name it getHeapSnapshot to avoid confusion with loading from filesystem and
for consistency with getCPUProfile.