[webkit-reviews] review denied: [Bug 101749] Web Inspector: Timeline: enhance short-records filter. : [Attachment 174435] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 14 00:24:29 PST 2012
Pavel Feldman <pfeldman at chromium.org> has denied eustas.bug at gmail.com's request
for review:
Bug 101749: Web Inspector: Timeline: enhance short-records filter.
https://bugs.webkit.org/show_bug.cgi?id=101749
Attachment 174435: Patch
https://bugs.webkit.org/attachment.cgi?id=174435&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=174435&action=review
Looks almost good. I don't think you should remove the 31* piece from
non-timeline panels.
> Source/WebCore/inspector/front-end/ProfilesPanel.js:1027
> + var minFloatingStatusBarItemsOffset =
lastItemElement.totalOffsetLeft() + lastItemElement.offsetWidth;
This will cause force layout.
More information about the webkit-reviews
mailing list