[webkit-reviews] review denied: [Bug 104835] Web Inspector: Don't throw exceptions in WebInspector.Color : [Attachment 179110] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied johnjbarton
<johnjbarton at chromium.org>'s request for review:
Bug 104835: Web Inspector: Don't throw exceptions in WebInspector.Color
https://bugs.webkit.org/show_bug.cgi?id=104835

Attachment 179110: Patch
https://bugs.webkit.org/attachment.cgi?id=179110&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179110&action=review


Looks good. Small style nit and annotation.

> Source/WebCore/inspector/front-end/Color.js:36
> +    this.valid = this._parse();

I'd rather introduce wrapper WebInspector.Color.parse(str) that would return
nullable Color. You can still leave _parse in place and make "valid" private
then. You'll simply return null when !color._valid.