[webkit-reviews] review granted: [Bug 87815] [Shadow DOM] ShadowRoot.getElementById() should work outside document : [Attachment 179425] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 87815: [Shadow DOM] ShadowRoot.getElementById() should work outside
document
https://bugs.webkit.org/show_bug.cgi?id=87815

Attachment 179425: Patch
https://bugs.webkit.org/attachment.cgi?id=179425&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=179425&action=review


It's surprising to see this doesn't hurt perf. But well, that happens. Wait for
bots beging green.

> Source/WebCore/dom/Node.cpp:2098
> +    if (parentNode() && parentNode()->isInShadowTree())

You can use parentOrHostNode() here. It will be a bit faster.