[webkit-reviews] review requested: [Bug 104911] [chromium] Add a virtual test suite for enabling opt-in to composited scrolling : [Attachment 179401] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 13 19:12:01 PST 2012


vollick at chromium.org has asked	for review:
Bug 104911: [chromium] Add a virtual test suite for enabling opt-in to
composited scrolling
https://bugs.webkit.org/show_bug.cgi?id=104911

Attachment 179401: Patch
https://bugs.webkit.org/attachment.cgi?id=179401&action=review

------- Additional Comments from vollick at chromium.org
(In reply to comment #14)
> (From update of attachment 179314 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=179314&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/port/chromium.py:396
> > +				 
['--enable-accelerated-compositing-for-overflow-scroll']),
> 
> This should be --enable-accelerated-overflow-scroll to match Chromium.  I
also think you need to add this option to DRT parsing in
Tools/DumpRenderTree/chromium/DumpRenderTree.cpp.

Gah, of course! This latest patch has the correct flag, and I've confirmed that
my plumbing does indeed make it in.


More information about the webkit-reviews mailing list