[webkit-reviews] review granted: [Bug 102599] ASSERT loading Acid3 test in run-safari --debug (r135050) : [Attachment 179381] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 102599: ASSERT loading Acid3 test in run-safari --debug (r135050)
https://bugs.webkit.org/show_bug.cgi?id=102599

Attachment 179381: Patch
https://bugs.webkit.org/attachment.cgi?id=179381&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=179381&action=review


> Source/WebCore/rendering/RenderLayerCompositor.cpp:1999
> +	   LayoutRect layerBounds = canBeComposited(layer) ?
layer->calculateLayerBounds(rootRenderLayer(), 0,
RenderLayer::DefaultCalculateLayerBoundsFlags

I don't think we need the canBeComposited() check, since needsToBeComposited()
already bails on this. I don't really know why calculateCompositedBounds() had
it.