[webkit-reviews] review granted: [Bug 104975] Callers should not have to stringify args before calling Executive run_command/popen : [Attachment 179373] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 104975: Callers should not have to stringify args before calling Executive
run_command/popen
https://bugs.webkit.org/show_bug.cgi?id=104975

Attachment 179373: Patch
https://bugs.webkit.org/attachment.cgi?id=179373&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179373&action=review


Can you verify that NRWT actually runs w/ this patch, since it broke last time
trying to start the http server?

> Tools/Scripts/webkitpy/common/system/executive.py:390
> +	   args = self._stringify_args(args)

You can probably now simplify _command_for_printing(), yes?