[webkit-reviews] review granted: [Bug 104925] Text Autosizing: Don't autosize unwrappable blocks : [Attachment 179287] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 13 15:09:21 PST 2012


Julien Chaffraix <jchaffraix at webkit.org> has granted John Mellor
<johnme at chromium.org>'s request for review:
Bug 104925: Text Autosizing: Don't autosize unwrappable blocks
https://bugs.webkit.org/show_bug.cgi?id=104925

Attachment 179287: Patch
https://bugs.webkit.org/attachment.cgi?id=179287&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179287&action=review


> Source/WebCore/ChangeLog:19
> +	       Use containerShouldbeAutosized instead of
contentHeightIsConstrained|

Not sure why you put a '|' at the end of your sentence, but AFAICT English uses
a '.' :)

> Source/WebCore/ChangeLog:25
> +	       Use containerShouldbeAutosized instead of
contentHeightIsConstrained|

Ditto.

> Source/WebCore/ChangeLog:27
> +	       Declared containerShouldbeAutosized

Missing final dot.


More information about the webkit-reviews mailing list