[webkit-reviews] review requested: [Bug 96614] Need to clear exception in JSDictionary for operations that might have. : [Attachment 179326] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 13 13:50:31 PST 2012


Michael Pruett <michael at 68k.org> has asked  for review:
Bug 96614: Need to clear exception in JSDictionary for operations that might
have.
https://bugs.webkit.org/show_bug.cgi?id=96614

Attachment 179326: Patch
https://bugs.webkit.org/attachment.cgi?id=179326&action=review

------- Additional Comments from Michael Pruett <michael at 68k.org>
I've removed the use of JSDictionary, simplified accessing arguments, and
changed WTF::getPtr() to .get(). I've also added a utility function for
converting a JSValue into an IDBKeyPath and updated the check for a script
execution context to throw an exception if no context is present.


More information about the webkit-reviews mailing list