[webkit-reviews] review granted: [Bug 104855] Block level pseudo elements bleed background color to <html> : [Attachment 179138] Patch

Thu Dec 13 13:15:42 PST 2012

Julien Chaffraix <jchaffraix at webkit.org> has granted Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 104855: Block level pseudo elements bleed background color to <html>
https://bugs.webkit.org/show_bug.cgi?id=104855

Attachment 179138: Patch
https://bugs.webkit.org/attachment.cgi?id=179138&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179138&action=review

> LayoutTests/ChangeLog:21
> +	   This was reported as a Chromium Bug:
> +	   https://code.google.com/p/chromium/issues/detail?id=75544

We usually don't put downstream bug here as they have little signification in
WebKit.

> LayoutTests/ChangeLog:23
> +

Extra space.

> LayoutTests/fast/css-generated-content/html-pseudo-background-color.html:8
> +    }

I think you should also check for html:after. Either in this test (with a
different color and the condition for passing would be "there should be no
background color" or another one.

> LayoutTests/fast/css-generated-content/html-pseudo-background-color.html:11
> +<p>

Your bug should say what it tests (ie include a description). Without the
ChangeLog, it is difficult to see what could go wrong.

Including the bug number and title is also nice.