[webkit-reviews] review granted: [Bug 104937] REGRESSION(r137406): NodeTraversal changes causing large renderer crash : [Attachment 179315] Fixes the bug

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 104937: REGRESSION(r137406): NodeTraversal changes causing large renderer
crash
https://bugs.webkit.org/show_bug.cgi?id=104937

Attachment 179315: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=179315&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=179315&action=review


> Source/WebCore/editing/FrameSelection.cpp:1958
> -    Element* element = start && start->isElementNode() ? toElement(start) :
ElementTraversal::next(start);
> +    if (!start)
> +	   return 0;
> +    Element* element = start->isElementNode() ? toElement(start) :
ElementTraversal::next(start);

I meant to write !start || start->isElementNode() here but this works too.