[webkit-reviews] review requested: [Bug 94743] Automatically use composited scrolling : [Attachment 179310] Patch

[bugzilla-daemon at webkit.org]

vollick at chromium.org has asked	for review:
Bug 94743: Automatically use composited scrolling
https://bugs.webkit.org/show_bug.cgi?id=94743

Attachment 179310: Patch
https://bugs.webkit.org/attachment.cgi?id=179310&action=review

------- Additional Comments from vollick at chromium.org
(In reply to comment #68)
> (From update of attachment 179183 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=179183&action=review
>
> The test looks a million times better than two patches ago, thanks!
>
> > Source/WebCore/rendering/RenderLayer.cpp:674
> > +void RenderLayer::updateLayerPositionsAfterOverflowScroll(bool
newlyPromoted)
>
> This is a bit of a nit, but this function feels a little bit overloaded. 
Unless I'm misunderstanding, it's kind of doing both
updateLayerPositionsAfterScroll and
positionOverflowControlsAfterPromotionToCompositedScrolling.  It might be more
clear to separate the two.
Good call -- this looks much better.
>
> > Source/WebCore/rendering/RenderLayer.h:758
> > +	 void updateIsNormalFlowOnly();
>
> Unused?

Yep, deleted.