[webkit-reviews] review requested: [Bug 61862] EventSource should support CORS : [Attachment 179305] patch 7

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 13 11:14:43 PST 2012


Per-Erik Brodin <per-erik.brodin at ericsson.com> has asked  for review:
Bug 61862: EventSource should support CORS
https://bugs.webkit.org/show_bug.cgi?id=61862

Attachment 179305: patch 7
https://bugs.webkit.org/attachment.cgi?id=179305&action=review

------- Additional Comments from Per-Erik Brodin <per-erik.brodin at ericsson.com>
Updated patch:
- Changed layoutTestController to testRunner in new tests
- Removed DefaultIsUndefined from the 'Optional' extended IDL attribute since
that is now the default for dictionaries
- Removed LogMessageType argument that has been removed from
addConsoleMessage()
- Simplified constructor argument test
- Updated more platform specific expected results for the constructor length
test
- Replaced enum with static const members to avoid style checker errors
- Removed 'int' from 'unsigned int' in method signature to avoid style checker
error


More information about the webkit-reviews mailing list