[webkit-reviews] review granted: [Bug 104891] Add --profiler=PROFILER option to run-perf-tests to allow specifying which profiler to use on platforms with many : [Attachment 179228] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 104891: Add --profiler=PROFILER option to run-perf-tests to allow
specifying which profiler to use on platforms with many
https://bugs.webkit.org/show_bug.cgi?id=104891

Attachment 179228: Patch
https://bugs.webkit.org/attachment.cgi?id=179228&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179228&action=review


> Tools/Scripts/webkitpy/common/system/executive.py:458
> +	   return subprocess.Popen(string_args, **kwargs)

I'm not sure that this is a great change ... it might be better to match the
underlying syntax and make the callers map to strings instead.