[webkit-reviews] review requested: [Bug 104911] [chromium] Add a virtual test suite for enabling opt-in to composited scrolling : [Attachment 179292] Patch

[bugzilla-daemon at webkit.org]

vollick at chromium.org has asked	for review:
Bug 104911: [chromium] Add a virtual test suite for enabling opt-in to
composited scrolling
https://bugs.webkit.org/show_bug.cgi?id=104911

Attachment 179292: Patch
https://bugs.webkit.org/attachment.cgi?id=179292&action=review

------- Additional Comments from vollick at chromium.org
(In reply to comment #2)
> (From update of attachment 179267 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=179267&action=review
>
> Is this to test the positioning of overflow scroll controls? Or, just general
repainting behavior?

I would like to verify this, yes, but mainly I want to ensure that when we
start automatically opting into composited scrolling, that we don't introduce
any unexpected regressions in these tests.

>
> > Tools/Scripts/webkitpy/layout_tests/port/chromium.py:399
> > +		
VirtualTestSuite('platform/chromium/virtual/gpu/compositedscrolling/overflow',
> > +				  'compositing/overflow',
> > +				 
['--enable-accelerated-compisiting-for-overflow-scroll',
'--force-compisiting-mode']),
> > +		
VirtualTestSuite('platform/chromium/virtual/gpu/compositedscrolling/scrollbars'
,
> > +				  'scrollbars',
> > +				 
['--enable-accelerated-compisiting-for-overflow-scroll',
'--force-compisiting-mode']),
>
> Typos.

Fixed.