[webkit-reviews] review canceled: [Bug 90405] CSS url() filters with forward references don't work : [Attachment 179189] Fix typo in debug build.

[bugzilla-daemon at webkit.org]

Stephen White <senorblanco at chromium.org> has canceled Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 90405: CSS url() filters with forward references don't work
https://bugs.webkit.org/show_bug.cgi?id=90405

Attachment 179189: Fix typo in debug build.
https://bugs.webkit.org/attachment.cgi?id=179189&action=review

------- Additional Comments from Stephen White <senorblanco at chromium.org>
I think the RenderObject changes are not a good idea at this time.   The
SVGResources class seems to cause asserts and crashes all over the place,
because it's not ready for non-SVG renderers.  And I don't think they're
necessary to fix the forward-references problem.  They may be necessary to fix
other problems, but I think we can deal with those in a subsequent patch.

My suspicion is that Keyar added the RenderObject::willBeDestroyed() call to
fix crashes, but it just papered over the deeper problem of the Element not
removing itself from the appropriate pending resources lists, as SVGElement
does.  I'll do some further investigation and tests to convince myself of that.