[webkit-reviews] review canceled: [Bug 104909] [Qt] The Qt's configuration isn't honoured regarding the use of the system libpng and libjpeg : [Attachment 179263] Patch

[bugzilla-daemon at webkit.org]

Jocelyn Turcotte <jocelyn.turcotte at digia.com> has canceled Jocelyn Turcotte
<jocelyn.turcotte at digia.com>'s request for review:
Bug 104909: [Qt] The Qt's configuration isn't honoured regarding the use of the
system libpng and libjpeg
https://bugs.webkit.org/show_bug.cgi?id=104909

Attachment 179263: Patch
https://bugs.webkit.org/attachment.cgi?id=179263&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at digia.com>
Yep so I agree that this is not a good solution, but the current situation
might soon be problematic too.
I talked with Tobias a bit and we'll run into problems if Qt is configured to
use any other version than the system default path's libraries and that we try
to load two versions of the same library as a result of WebKit having its own
system dependencies.
This hasn't been a problem before since we always religiously tried not to use
anything outside qt/src/3rdparty.

A solution would be to delegate all our configuration work to Qt and get the
result down to every modules.
"Oh you need sqlite? Here I did the work for you, just add this and this to
your build flags."

If necessary, the need behind this patch is mostly explained in the ChangeLog.