[webkit-reviews] review granted: [Bug 104347] Coordinated Graphics: Remove the dependency of WebCoordinatedSurface::Handle from Coordinated Graphics. : [Attachment 178985] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has granted Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 104347: Coordinated Graphics: Remove the dependency of
WebCoordinatedSurface::Handle from Coordinated Graphics.
https://bugs.webkit.org/show_bug.cgi?id=104347

Attachment 178985: Patch
https://bugs.webkit.org/attachment.cgi?id=178985&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178985&action=review


Note that I r+/cq- those patches. Please work with guys at #qtwebkit to make
sure you submit those patches gradually without breaking anything.

> Source/WebKit2/ChangeLog:15
> +	   CoordinatedImageBacking. Now CoordinatedLayerTreeHost treats with
the
> +	   Handle.

treats with the handles -> converts the handle to a WebCoordinatedSurface.

>
Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.c
pp:118
> +    // If failing to send the message, try again in the next update.

If sending the message fails

> Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp:45
> +    // FIXME: We need to find more elegant way.
> +    if (!m_client->createUpdateAtlas(m_ID, m_surface))
> +	   m_surface.clear();

What's not elegant?