[webkit-reviews] review granted: [Bug 103366] [TexMap] Perform the layer-tree traversal in GraphicsLayerTextureMapper. : [Attachment 178934] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has granted Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 103366: [TexMap] Perform the layer-tree traversal in
GraphicsLayerTextureMapper.
https://bugs.webkit.org/show_bug.cgi?id=103366

Attachment 178934: Patch
https://bugs.webkit.org/attachment.cgi?id=178934&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178934&action=review


I'm OK with this. I'd rather someone else cq+ if things are stable enough for
this.

> Source/WebCore/ChangeLog:19
> +	   In addition, this patch removes SyncOptions enum. Currently, when
using
> +	   ComputationsOnly, the layer-tree traversal synchronizes only
animations
> +	   without layer states. However, there is no client that calls
> +	   flushCompositingState() for the purpose. Even we already have the
API
> +	   for the purpose: applyAnimationsRecursively(). So from now on, we
have
> +	   only flushCompositingStateForThisLayerOnly() API in
TextureMapperLayer
> +	   for brevity.

Just say:
Also removed the SyncOptions enum, which is redundant since no client calls it
with ComputationsOnly.