[webkit-reviews] review requested: [Bug 104690] [EFL] The WebKit2 bots are building and executing WebKit1 tests : [Attachment 179258] Patch

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has asked  for review:
Bug 104690: [EFL] The WebKit2 bots are building and executing WebKit1 tests
https://bugs.webkit.org/show_bug.cgi?id=104690

Attachment 179258: Patch
https://bugs.webkit.org/attachment.cgi?id=179258&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179258&action=review


The idea is good.

Let me to think about the master.cfg change a little bit.

> Tools/Scripts/build-webkit:63
> +my $onlyWebKit2 = 0;

noWebKit1 similar to noWebKit2

> Tools/Scripts/build-webkit:140
> +  --only-webkit2		       Build only the WebKit2 project (EFL
only)
> +

I prefer --no-webkit1, similar to --no-webkit2.

> Tools/Scripts/build-webkit:155
> +    'only-webkit2' => \$onlyWebKit2,

ditto.