[webkit-reviews] review granted: [Bug 104903] Web Inspector: Native Memory Instrumentation: do not validate pointers to objects in RenderArena agains tcmalloc data : [Attachment 179262] comments addressed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 13 06:19:42 PST 2012


Yury Semikhatsky <yurys at chromium.org> has granted Ilya Tikhonovsky
<loislo at chromium.org>'s request for review:
Bug 104903: Web Inspector: Native Memory Instrumentation: do not validate
pointers to objects in RenderArena agains tcmalloc data
https://bugs.webkit.org/show_bug.cgi?id=104903

Attachment 179262: comments addressed
https://bugs.webkit.org/attachment.cgi?id=179262&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179262&action=review


> Source/WTF/wtf/MemoryObjectInfo.h:62
> +    void setCustomAllocation(bool customAllocation) { m_customAllocation =
customAllocation; }

Are we ever going to call this with customAllocation = false ?


More information about the webkit-reviews mailing list