[webkit-reviews] review granted: [Bug 101135] [EFL] Remove redundant pipe write to prevent pipe buffer full. : [Attachment 178817] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 13 00:30:47 PST 2012


Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Byungwoo Lee
<bw80.lee at samsung.com>'s request for review:
Bug 101135: [EFL] Remove redundant pipe write to prevent pipe buffer full.
https://bugs.webkit.org/show_bug.cgi?id=101135

Attachment 178817: Patch
https://bugs.webkit.org/attachment.cgi?id=178817&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=178817&action=review


This patch is same issue with Bug 101132. We need to use a lock for
ecore_pipe_write for now because ecore_pipe_write is intended for a thread. Set
r+ based on informal review thread.

> Source/WebCore/ChangeLog:12
> +	   uses PISIX pipe write with O_NONBLOCK disabled.

PISIX -> POSIX ?


More information about the webkit-reviews mailing list