[webkit-reviews] review denied: [Bug 104764] Handling autoscroll in EventHandler should be re-factor : [Attachment 179212] Patch 5

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has denied yosin at chromium.org's request for
review:
Bug 104764: Handling autoscroll in EventHandler should be re-factor
https://bugs.webkit.org/show_bug.cgi?id=104764

Attachment 179212: Patch 5
https://bugs.webkit.org/attachment.cgi?id=179212&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=179212&action=review


This looks much better!

> Source/WebCore/page/EventHandler.h:118
> +    AutoscrollController& autoscrollController() { return
m_autoscrollController; }

Let's kill this. We can just provide didPanScrollStop() and didPanScrollStart()
or something to limit the usage.

> Source/WebCore/page/EventHandler.h:404
> +    AutoscrollController m_autoscrollController;

And make this OwnPtr. Then we can hide AutoscrollController.h in
EventHandler.cpp.