[webkit-reviews] review denied: [Bug 104354] IndexedDB: Don't use strings to represent serialized values : [Attachment 178915] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has denied Michael Pruett
<michael at 68k.org>'s request for review:
Bug 104354: IndexedDB: Don't use strings to represent serialized values
https://bugs.webkit.org/show_bug.cgi?id=104354

Attachment 178915: Patch
https://bugs.webkit.org/attachment.cgi?id=178915&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178915&action=review


BTW, don't you have any performance concern about this change? (Is there any
benchmark that we can use to make sure that this change won't regress
performance?)

> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:1406
> +    Vector<uint8_t> m_emptyValue;

Do you need this member?

> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:1528
> +    Vector<uint8_t> m_emptyValue;

Ditto.

> Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp:1610
> +    Vector<uint8_t> m_value;

Nit: Rename to m_currentValue, as you're using m_currentValue above.