[webkit-reviews] review requested: [Bug 103843] Coordinated Graphics: Reorder messages to LayerTreeCoordinatorProxy : [Attachment 179199] Patch: Clarify LayerTreeRenderer::setRootLayerID() can be called only once

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 12 22:41:09 PST 2012


Huang Dongsung <luxtella at company100.net> has asked  for review:
Bug 103843: Coordinated Graphics: Reorder messages to LayerTreeCoordinatorProxy
https://bugs.webkit.org/show_bug.cgi?id=103843

Attachment 179199: Patch: Clarify LayerTreeRenderer::setRootLayerID() can be
called only once 
https://bugs.webkit.org/attachment.cgi?id=179199&action=review

------- Additional Comments from Huang Dongsung <luxtella at company100.net>
Turn on r? because code is little changed.

Previous patch added following assertion.
+    ASSERT(layerID != m_rootLayerID);
+    ASSERT(layerID != InvalidWebLayerID);

This patch added following assertion.
+    ASSERT(layerID != InvalidCoordinatedLayerID);
+    ASSERT(m_rootLayerID == InvalidCoordinatedLayerID);

This assertion is more strict.


More information about the webkit-reviews mailing list