[webkit-reviews] review granted: [Bug 104873] Validity of a radio button is not updated correctly when it is detached from an invalid radio group : [Attachment 179192] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 104873: Validity of a radio button is not updated correctly when it is
detached from an invalid radio group
https://bugs.webkit.org/show_bug.cgi?id=104873

Attachment 179192: Patch
https://bugs.webkit.org/attachment.cgi?id=179192&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=179192&action=review


> Source/WebCore/html/HTMLInputElement.cpp:1776
> -bool HTMLInputElement::isInRequiredRadioButtonGroup() const
> +bool HTMLInputElement::isInRequiredRadioButtonGroup()

Why do you need to remove const ?

> Source/WebCore/html/HTMLInputElement.h:248
> -    bool isInRequiredRadioButtonGroup() const;
> +    bool isInRequiredRadioButtonGroup();

Ditto.

> LayoutTests/fast/forms/radio/radio-live-validation-style.html:37
> +shouldBeTrue('$("radio1").remove(); radio2.remove();
radio2.webkitMatchesSelector(":valid")');

You might want to also check that radio2.webkitMatchesSelector(":valid") is
false before removing radio2.