[webkit-reviews] review granted: [Bug 104631] Emphasis mark is printed after inline-block with justify : [Attachment 178957] Update TestExpectations

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Yuki Sekiguchi
<yuki.sekiguchi at access-company.com>'s request for review:
Bug 104631: Emphasis mark is printed after inline-block with justify
https://bugs.webkit.org/show_bug.cgi?id=104631

Attachment 178957: Update TestExpectations
https://bugs.webkit.org/attachment.cgi?id=178957&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=178957&action=review


Some grammar changes. This is my first review of text layout, so I'm quite
nervous and I hope I don't break anything :(

> Source/WebCore/ChangeLog:8
> +	   Fix emphasis mark is printed after inline-block with justify.

-> "Do not print an emphasis mark after an inline-block when justified."

> Source/WebCore/ChangeLog:14
> +	   If an inline-block is expanded, a space is added after inline-block.

> +	   Emphasis mark is drawn over the space for the expand.
> +
> +	   When an emphasis mark is drawn, check the charactor is the space.
> +	   If so, don't draw emphasis mark.

-> "If an inline-block is expanded, it has a space appended to it. This space
should not have any emphasis marks drawn."

> Source/WebCore/platform/graphics/WidthIterator.cpp:228
> +				       glyphBuffer->add(0, fontData,
m_expansionPerOpportunity);

I wonder if we should have a special name for a null glyph, or a glyph we don't
care about?

> LayoutTests/ChangeLog:8
> +	   Test that draw emphasis mark to justified inline box and text.

-> Test that emphasis marks are not drawn incorrectly in justified text with
inline boxes.