[webkit-reviews] review granted: [Bug 104586] [chromium] Expose quickRedirectComing via WebDataSource : [Attachment 178904] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 12 16:28:02 PST 2012


Nate Chapin <japhet at chromium.org> has granted Charles Reis
<creis at chromium.org>'s request for review:
Bug 104586: [chromium] Expose quickRedirectComing via WebDataSource
https://bugs.webkit.org/show_bug.cgi?id=104586

Attachment 178904: Patch
https://bugs.webkit.org/attachment.cgi?id=178904&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=178904&action=review


> Source/WebKit/chromium/src/WebDataSourceImpl.cpp:93
> +bool WebDataSourceImpl::isClientRedirect() const
> +{
> +    // FIXME: This should return DocumentLoader::isClientRedirect() once
that is
> +    // changed to be set earlier than the call to
WebFrameClient::decidePolicyForNavigation.
> +    return frameLoader() ? frameLoader()->quickRedirectComing() : false;
> +}
> +

I worry about depending on quickRedirectComing(), but I understand that using
DocumentLoader::isClientRedirect() is a much more complex undertaking. So long
as we tackle this FIXME sometime soon, this LGTM.


More information about the webkit-reviews mailing list