[webkit-reviews] review requested: [Bug 49246] Main resource should be cached in the memory cache : [Attachment 179139] Re-land after revert

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 12 15:53:27 PST 2012


Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 49246: Main resource should be cached in the memory cache
https://bugs.webkit.org/show_bug.cgi?id=49246

Attachment 179139: Re-land after revert
https://bugs.webkit.org/attachment.cgi?id=179139&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
Differences from r137333:

* clearResource() is called in MainResourceLoader's destructor, so we don't
leak m_resource
* No modifications to http/tests/inspector/resource-parameters.html
* Fragment identifier reconstruction is no longer necessary at the end of
MainResourceLoader::load().

Note that until bug 104721 lands, http/tests/inspector/resource-parameters.html
will fail, so EWS for this patch is not excepted to be 100% green.


More information about the webkit-reviews mailing list